ryexandrite
  • Joined on Aug 30, 2020
Loading Heatmap…

ryexandrite commented on pull request hexbear-collective/lemmy-hexbear#296

feature/keyword-filtering-main

Per the rust documentation https://docs.rs/regex/1.4.5/regex/#untrusted-input > Untrusted regular expressions are handled by capping the size of a compiled regular expression. (See…

9 months ago

ryexandrite commented on pull request hexbear-collective/lemmy-hexbear#296

feature/keyword-filtering-main

@zongor @DashEightMate I think the one main inprovment is that insted of compialing multiple regex they should be concatenated into one large regex and compiled once. This means that the DFA is…

9 months ago

ryexandrite commented on pull request hexbear-collective/lemmy-hexbear#296

feature/keyword-filtering-main

@DashEightMate by a plaintext containes check do you mean in the sql query itself? If so I'm not sure how I feel about that. the use of a sql `ILIKE` is a heavy performance hit for the database it…

9 months ago

ryexandrite commented on pull request hexbear-collective/lemmy-hexbear#296

feature/keyword-filtering-main

I'm as of yet unconvinced on the regex functionality. I'd be a lot more comfertable with striping grouping regex charateres and only allowing `[]\.*+?`. Rust has the memory safty to prevent large…

10 months ago

ryexandrite commented on pull request hexbear-collective/lemmy-hexbear#296

feature/keyword-filtering-main

this is what I was worried about, good catch.

10 months ago

ryexandrite commented on pull request hexbear-collective/lemmy-hexbear#296

feature/keyword-filtering-main

yes, same sugestion I made for the comments, good catch.

10 months ago

ryexandrite commented on pull request hexbear-collective/hexbear-frontend#172

Add keyword filtering UI

NOTE: do not merge this until hexbear-collective/lemmy-hexbear#296 is also merged

10 months ago

ryexandrite approved hexbear-collective/hexbear-frontend#172

Add keyword filtering UI

We'll want to come up with an alt color for the secondary color I think.

10 months ago

ryexandrite commented on pull request hexbear-collective/hexbear-frontend#172

Add keyword filtering UI

as long as we can put in place midigations to prevent regex computation / exacution time and memory exploits in the backend (which rust supports) I think we can be ok allowing regex special chars.

10 months ago

ryexandrite commented on pull request hexbear-collective/lemmy-hexbear#296

feature/keyword-filtering-main

we will need to do some testing to make sure this can't be abused we dont; want someone constructing an obsurdly expensive regex. if you can, please take a look at…

10 months ago

ryexandrite suggested changes for hexbear-collective/lemmy-hexbear#296

feature/keyword-filtering-main

Looking good, I think there needs to be some final changes to how the comment filter is done for efficiency but this is otherwise looking good.

10 months ago

ryexandrite commented on pull request hexbear-collective/lemmy-hexbear#296

feature/keyword-filtering-main

This itterator too may run when it is not needed. we only need to iterate if there are comments to filter. a check for `bad_comment_ids.is_empty()` would be best.

10 months ago

ryexandrite commented on pull request hexbear-collective/lemmy-hexbear#296

feature/keyword-filtering-main

This loop seems inefficient to me.

10 months ago

ryexandrite commented on pull request hexbear-collective/lemmy-hexbear#296

feature/keyword-filtering-main

ok, I think we can trust it in that respect if things compile.

10 months ago

ryexandrite commented on pull request hexbear-collective/hexbear-frontend#172

Add keyword filtering UI

is that blue color of the keywords tied to the theme?

10 months ago

ryexandrite commented on pull request hexbear-collective/hexbear-frontend#172

Add keyword filtering UI

ah, my bad. for some reason I was thinking these were somthing local.

10 months ago

ryexandrite commented on pull request hexbear-collective/hexbear-frontend#172

Add keyword filtering UI

Is there a better name for these component than `Disclosure`?

10 months ago

ryexandrite dismissed review from ryexandrite for hexbear-collective/hexbear-frontend#172

Reason:

10 months ago